Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(jshint): enforce jshint for tests#7264

Closed
shahata wants to merge 1 commit into
angular:masterfrom
shahata:test-jshint
Closed

chore(jshint): enforce jshint for tests#7264
shahata wants to merge 1 commit into
angular:masterfrom
shahata:test-jshint

Conversation

@shahata
Copy link
Copy Markdown
Contributor

@shahata shahata commented Apr 26, 2014

No description provided.

@mary-poppins
Copy link
Copy Markdown

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7264)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@shahata
Copy link
Copy Markdown
Contributor Author

shahata commented Apr 26, 2014

This loads very slowly in Github since there are a lot of differences. Use this URL in order to ignore whitespace differences: https://github.com/angular/angular.js/pull/7264/files?w=1 (it will load much fatser)

@petebacondarwin
Copy link
Copy Markdown
Contributor

Very nice work sir!

Comment thread Gruntfile.js
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is best to use files[...] here so that we keep all file references in a single place, no?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see that we don't do it for the other modules!

@petebacondarwin
Copy link
Copy Markdown
Contributor

Do you fancy doing the same for the 1.2.x branch? :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants