Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(docs.css): add media query fix#7079

Closed
fijimunkii wants to merge 1 commit into
angular:masterfrom
fijimunkii:master
Closed

docs(docs.css): add media query fix#7079
fijimunkii wants to merge 1 commit into
angular:masterfrom
fijimunkii:master

Conversation

@fijimunkii

@fijimunkii fijimunkii commented Apr 10, 2014

Copy link
Copy Markdown

Request Type: docs

How to reproduce: resize browser to between 992px and 768px

Component(s):

Impact:

Complexity: small

This issue is related to:

Detailed Description:

Other Comments:

show main-body content that is hidden underneath bootstrap navbar
between 992px and 768px screen width

@mary-poppins

mary-poppins commented Apr 10, 2014

Copy link
Copy Markdown

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7079)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@fijimunkii
docs(docs.css): add media query fix
8143ffd 
show main-body content that is hidden underneath bootstrap navbar
between 992px and 768px screen width

Closes angular#7079
@mary-poppins

mary-poppins commented Apr 11, 2014

Copy link
Copy Markdown

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@fijimunkii

fijimunkii commented Apr 11, 2014

Copy link
Copy Markdown
Author

Not a problem, I just signed it again with the email used for the commit.

@mary-poppins

mary-poppins commented Apr 11, 2014

Copy link
Copy Markdown

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@Narretz Narretz mentioned this pull request Apr 14, 2014
Closed
@petebacondarwin

petebacondarwin commented May 16, 2014

Copy link
Copy Markdown
Contributor

Duplicate of #6474. The only difference was one height in the CSS but @Narretz fix seems to work for me.

petebacondarwin pushed a commit that referenced this pull request May 16, 2014
@Narretz @petebacondarwin
chore(docs): fix layout between 769px and 991px
f440ac7 
Left nav and main content were tucked slightly under the version picker / breadcrumb navbar

Closes #6474
Closes #7079
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fijimunkii @mary-poppins @petebacondarwin