This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(version-info): explicitly specify the remote#6678
Closed
chirayuk wants to merge 1 commit into
Closed
Conversation
|
Love it, Chirayu! ❤️ |
`git ls-remote --tags` assumes that you have a remote set up for your current branch. That isn't the case, at least for me, when I'm working on local branches. `grunt write` doesn't do the right thing in that case (`git ls-remote --tags` bails out and the silent: true param makes this a pain to debug.) Prefer explicit to implicit.
Contributor
|
LGTM. Let's merge this. |
Contributor
|
Thanks! |
chirayuk
added a commit
that referenced
this pull request
Mar 20, 2014
`git ls-remote --tags` assumes that you have a remote set up for your current branch. That isn't the case, at least for me, when I'm working on local branches. `grunt write` doesn't do the right thing in that case (`git ls-remote --tags` bails out and the silent: true param makes this a pain to debug.) Prefer explicit to implicit. Closes #6678.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git ls-remote --tagsassumes that you have a remote set up for yourcurrent branch. That isn't the case, at least for me, when I'm working
on local branches.
grunt writedoesn't do the right thing in thatcase (
git ls-remote --tagsbails out and the silent: true param makesthis a pain to debug.) Prefer explicit to implicit.