This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(loader): don't rely on functions defined in Angular.js#4874
Closed
petebacondarwin wants to merge 1 commit into
Closed
fix(loader): don't rely on functions defined in Angular.js#4874petebacondarwin wants to merge 1 commit into
petebacondarwin wants to merge 1 commit into
Conversation
Contributor
Author
|
Fixes #4437 |
This was referenced Nov 10, 2013
Contributor
|
I have only concern about the code size. The This change increases the size (because of including the miner): There is only a single exception, so I'm thinking, is it worthy? |
Contributor
|
@petebacondarwin can you add |
Contributor
|
Also, minErr uses other angular internal functions such as |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
This significantly increases the size of the loader: - minified: 1031bytes -> 1509bytes (+46%) - minified + gzip: 593bytes -> 810bytes (+36%) I'm not entirely sold on the idea of shipping minErr with the loade. With the current state, the angular-loader behavior is completely broken - this is just a quick fix, we can revisit this change in the future. Closes angular#4437 Closes angular#4874
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
This significantly increases the size of the loader: - minified: 1031bytes -> 1509bytes (+46%) - minified + gzip: 593bytes -> 810bytes (+36%) I'm not entirely sold on the idea of shipping minErr with the loade. With the current state, the angular-loader behavior is completely broken - this is just a quick fix, we can revisit this change in the future. Closes angular#4437 Closes angular#4874
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loader had not been tested since minErr had been implemented so was breaking the phonecat tutorial application. Moreover I had added a call to
assertNotHasOwnProperty, not understanding that loader does not get access to Angular.js functions.The loader now has its own copies of minErr (via AngularFiles.js) and
assertNotHasOwnProperty.