This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Respect PORT from URL without escaping#2652
Closed
Conversation
Allows to write urls normally.
Contributor
|
This is an interesting idea. What you are saying is that since parameters cannot be identified as a number, then any parameter starting with a colon and only containing digits (e.g. I like this. @IgorMinar - is there any reason why this should break previous functionality? |
Contributor
PR Checklist (Minor Feature)
|
Contributor
There was a problem hiding this comment.
typo : "por" -> "an"
Contributor
Author
There was a problem hiding this comment.
My bad. This is to be fixed.
Contributor
Author
There was a problem hiding this comment.
it('should support unescaped port in url'), function() {
Is this better?
There was a problem hiding this comment.
I think it should be "should support an unescaped port in url"
Contributor
Author
|
@petebacondarwin My full name is Leandro Ostera Villalva. |
Contributor
|
This PR has moved to #2778 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to write a URL normally.
Escaping the port does not comply with the URL syntax
Regular Expression and it's position in the if clause are meant to short-circuit ASAP.