This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($location): decode non-component special chars in Hashbang URLS#16350
Merged
petebacondarwin merged 1 commit intoNov 30, 2017
Merged
Conversation
3 tasks
gkalpak
approved these changes
Nov 28, 2017
Member
|
🙈 |
Contributor
Author
Is that you washing your hands of this @gkalpak ? |
Contributor
Author
|
Well this is a bit annoying: (https://travis-ci.org/angular/angular.js/jobs/308460518#L559) |
Contributor
|
True. But it's the last check, so everything else has passed and you can merge it anyway. |
|
Good timing! Just ran into and debugged this in g3, finding the same issue. Thanks @petebacondarwin! |
|
Should I wait for the next version to go out to get this fix? |
Member
|
It should be in 1.6.8, which is expected to come out very soon 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16316 (comment)