This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feature($resource): Add Resource To Response For Error Interceptors#16109
Closed
kmccullough wants to merge 1 commit into
Closed
feature($resource): Add Resource To Response For Error Interceptors#16109kmccullough wants to merge 1 commit into
kmccullough wants to merge 1 commit into
Conversation
3 tasks
gkalpak
suggested changes
Jul 14, 2017
Member
gkalpak
left a comment
There was a problem hiding this comment.
Could you please add some docs for that. I think the behavior of adding resource to the response is not documented (and it should be).
(If you don't feel like adding the docs, it's OK 😃)
LGTM otherwise 👍
Contributor
Author
|
@gkalpak How's that? |
gkalpak
approved these changes
Jul 18, 2017
gkalpak
pushed a commit
that referenced
this pull request
Jul 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Similar to how the resource object (which is to be populated later) is added to the response for a successful request and accessible to the response interceptor, this change attaches the resource object to the response for a failed request and is accessible by the responseError interceptor.
What is the current behavior? (You can also link to an open issue here)
The resource object is not accessible from the responseError interceptor.
What is the new behavior (if this is a feature change)?
The resource object is accessible from the responseError interceptor.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information: