docs(ngClass): Add docs for ngClassOdd and ngClassEven regarding anim…#15654
docs(ngClass): Add docs for ngClassOdd and ngClassEven regarding anim…#15654frederikprijck wants to merge 2 commits into
Conversation
…ClassOdd` Previously, the documentation has no information regarding using `ngAnimate` together with the `ngClassEven` and `ngClassOdd` directives. This commit adds the same docs used by the `ngClass` directive to the `ngClassEven` and `ngClassOdd` docs and adds an extra example for both `ngClassEven` and `ngClassOdd` that showcases animations.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
…and `ngClassOdd`
gkalpak
left a comment
There was a problem hiding this comment.
Made some changes to the examples, updated some links in the animations guide, and rebased on master.
…ClassOdd` Previously, the documentation has no information regarding using `ngAnimate` together with the `ngClassEven` and `ngClassOdd` directives. This commit adds the same docs used by the `ngClass` directive to the `ngClassEven` and `ngClassOdd` docs and adds an extra example for both `ngClassEven` and `ngClassOdd` that showcases animations. Closes #15654
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
The documentation has no information regarding using
animationtogether with thengClassOddandngClassEvendirective.What is the new behavior (if this is a feature change)?
This commit adds the same docs used by the
ngClassdirective to thengClassOddandngClassEvendocs and adds an extra example for bothngClassOddandngClassEven.Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: