Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs: adding languages for code blocks that don't have#15357

Closed
NoHomey wants to merge 1 commit into
angular:masterfrom
NoHomey:changelog
Closed

docs: adding languages for code blocks that don't have#15357
NoHomey wants to merge 1 commit into
angular:masterfrom
NoHomey:changelog

Conversation

@NoHomey
Copy link
Copy Markdown
Contributor

@NoHomey NoHomey commented Nov 3, 2016

fixes #15356.

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@NoHomey
Copy link
Copy Markdown
Contributor Author

NoHomey commented Nov 3, 2016

It looks like you've already signed this CLA. If you'd like to edit your contact information, you may do so below.

@NoHomey
Copy link
Copy Markdown
Contributor Author

NoHomey commented Nov 3, 2016

I signed it!

@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Nov 4, 2016

You have used the same author-email for the commit as for signing the CLA, right? (Just making sure 😁)

@gkalpak
Copy link
Copy Markdown
Member

gkalpak commented Nov 4, 2016

@NoHomey, can you make sure the commit message adheres to our commit guidelines?
Other than that LGTM.

…roper syntax highlighting

Add missing language identifier to code blocks that don't have one specified.
Required for proper syntax highlighting of code blocks used as examples.

Closes angular#15356
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 5, 2016
@NoHomey
Copy link
Copy Markdown
Contributor Author

NoHomey commented Nov 5, 2016

@gkalpak thanks for the reminder for the email I actually did not configured git before commiting (did it in a hurry during the brake in the university, totally forgot about it 😃) .

@gkalpak gkalpak closed this in 810a3e4 Nov 5, 2016
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
…ghting

Add missing language identifiers to code blocks used as examples, in order to
have proper syntax highlighting.

Fixes angular#15356

Closes angular#15357
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Some of code examples in CHANGELOG.md are missing language

3 participants