This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Update Protractor to 4.0.0 and use FF 47 in e2e tests on Travis#14912
Merged
Conversation
f4d4287 to
c48225e
Compare
Member
|
According to the changelog, we should not be using Can you also make sure that this doesn't break with 482a3ae (which involves quite a bit of scrolling)? |
Closed
3 tasks
Contributor
Author
|
@gkalpak You don't know by any chance what the migration for getInnerHTML ist? Simply accessing the property? |
Member
|
From what I understand |
30a933c to
4e5b230
Compare
4.0.0 is the first version with Selenium 2.53.x, and we need that as lower versions have problems with current Firefox versions. See SeleniumHQ/selenium#1202 and SeleniumHQ/selenium#2110. We are currently running tests on FF28. As part of the update the deprecated webdriver fn getInnerHtml has been replaced with getAttribute('innerHTML')
This commit also adds a new capability to the protractor configs that ensures that all angularjs.org tests run correctly on Firefox. See SeleniumHQ/selenium#1202
4e5b230 to
1d4216a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.