Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Components): snake -> kebab#14464

Merged
Narretz merged 1 commit into
angular:masterfrom
knpwrs:patch-1
Apr 19, 2016
Merged

docs(guide/Components): snake -> kebab#14464
Narretz merged 1 commit into
angular:masterfrom
knpwrs:patch-1

Conversation

@knpwrs

@knpwrs knpwrs commented Apr 19, 2016

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Doc correction.

What is the current behavior? (You can also link to an open issue here)

Docs mention snake_case.

What is the new behavior (if this is a feature change)?

Example given is actually kebab-case.

Does this PR introduce a breaking change?

No.

Please check if the PR fulfills these requirements

Other information:

The example given is not in snake_case, it is in kebab-case.

@knpwrs
docs(guide/Components): snake -> kebab
df97b91 
The example given is not in snake_case, it is in kebab-case.
@googlebot

googlebot commented Apr 19, 2016

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot

googlebot commented Apr 19, 2016

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@knpwrs

knpwrs commented Apr 19, 2016

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

googlebot commented Apr 19, 2016

Copy link
Copy Markdown

CLAs look good, thanks!

1 similar comment
@googlebot

googlebot commented Apr 19, 2016

Copy link
Copy Markdown

CLAs look good, thanks!

@Narretz Narretz merged commit e14b486 into angular:master Apr 19, 2016
Narretz pushed a commit that referenced this pull request Apr 19, 2016
@knpwrs @Narretz
docs(guide/Components): change snake to kebab case
da7af93 
The example given is not in snake_case, it is in kebab-case.

Closes #14464
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knpwrs @googlebot @Narretz