This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngOptions): throw if ngModel is not present#12840
Closed
Narretz wants to merge 1 commit into
Closed
Conversation
Closes angular#7047 Closes angular#12840 BREAKING CHANGE: `ngOptions` will now throw if `ngModel` is not present on the `select` element. Previously, having no `ngModel` let `ngOptions` silently fail, which could lead to hard to debug errors. The change should therefore not affect any applications, as it simply makes the requirement more strict and alerts the developer explicitly.
47978a6 to
ff231a9
Compare
Contributor
|
LGTM. Please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
ngOptionswill now throw ifngModelis not present on theselectelement. Previously, having no
ngModelletngOptionssilentlyfail, which could lead to hard to debug errors. The change should
therefore not affect any applications, as it simply makes the
requirement more strict and alerts the developer explicitly.