Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update ngModel.js documentation#12498

Closed
akhlesh wants to merge 1 commit into
angular:masterfrom
akhlesh:patch-2
Closed

Update ngModel.js documentation#12498
akhlesh wants to merge 1 commit into
angular:masterfrom
akhlesh:patch-2

Conversation

@akhlesh
Copy link
Copy Markdown
Contributor

@akhlesh akhlesh commented Aug 4, 2015

ngModel documentation says that $setViewValue doesn't trigger a '$digest' but its does. it triggers $apply.

ngModel documentation says that $setViewValue doesn't trigger a '$digest' but its does. it triggers $apply.
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@akhlesh
Copy link
Copy Markdown
Contributor Author

akhlesh commented Aug 4, 2015

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Aug 4, 2015
@Narretz Narretz added this to the Backlog milestone Aug 8, 2015
@Narretz
Copy link
Copy Markdown
Contributor

Narretz commented Aug 9, 2015

Hey @akhlesh thanks for the PR. The change is not completely correct, though. First, an $apply triggers a $digest, so this is basically correct.
The second part is a bit more complex. $setViewValue will only trigger a $digest if you haven't specified specific updateOn triggers, like blur. If you have specified a debounce it'll be triggered only after the debounce.
Do you think you could incorporate this information into the PR?

@Narretz Narretz modified the milestones: Ice Box, Backlog Aug 9, 2015
@akhlesh
Copy link
Copy Markdown
Contributor Author

akhlesh commented Aug 17, 2015

@Narretz so $setviewValue always calls $digest at some point of time.
sure i'll make this change in my PR.

@Narretz Narretz closed this in 4175860 Sep 1, 2015
@akhlesh akhlesh deleted the patch-2 branch April 28, 2016 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants