Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

event.preventDefault() for links in Opera#1205

Closed
sgtpep wants to merge 1 commit into
angular:masterfrom
sgtpep:patch-1
Closed

event.preventDefault() for links in Opera#1205
sgtpep wants to merge 1 commit into
angular:masterfrom
sgtpep:patch-1

Conversation

@sgtpep
Copy link
Copy Markdown
Contributor

@sgtpep sgtpep commented Jul 26, 2012

I began to test my angular application in recent Opera (12.00, OS X) and found that clicking the links without href attribute does not always prevented, so it messes up navigation. Adding the "return false" fixes the issue to me.

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Sep 5, 2012

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement).

CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form):
http://code.google.com/legal/individual-cla-v1.0.html

For corporations (print, sign and scan+email, fax or mail):
http://code.google.com/legal/corporate-cla-v1.0.html

@sgtpep
Copy link
Copy Markdown
Contributor Author

sgtpep commented Sep 6, 2012

I have signed it electronically. My full name (without middle name) you could find on profile page https://github.com/sgtpep.

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Sep 6, 2012

MERGED

@mhevery mhevery closed this Sep 6, 2012
@chicoxyzzy
Copy link
Copy Markdown

It causes various bugs! Please see #1651, #1674, #1662, #1729
For my issue #1729 this not fixes even Opera behavior it must fix

@IgorMinar
Copy link
Copy Markdown
Contributor

this commit got reverted by 14948cf.

@sgtpep if you can provide a test case for opera that shows the buggy behavior, we'll fix it in a different way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants