This repository was archived by the owner on Apr 12, 2024. It is now read-only.
perf($compile): only use document fragments when necessary#12041
Closed
jbedard wants to merge 1 commit into
Closed
perf($compile): only use document fragments when necessary#12041jbedard wants to merge 1 commit into
jbedard wants to merge 1 commit into
Conversation
Contributor
|
I am not sure about this change. I see that there might be some performance improvements, but it will also break calling |
Contributor
Author
|
Really it's just for groupScan. Once a node has been replaced I don't think anything is supported on that node? Doesn't mean people don't use it though. I could change this to just update the comment instead? |
Contributor
Author
Contributor
Contributor
|
Closing in favour of #12094 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mainly just explains the TODO(perf). I'm sure the actual impact is negligible, but will avoid creating fragments in the majority of cases (where only one node is being replaced).
(this is a subset of #9365 that can be done on it's own)