Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(filter/number): Change description of returned value#11963

Closed
calamarico wants to merge 1 commit into
angular:masterfrom
calamarico:patch-1
Closed

docs(filter/number): Change description of returned value#11963
calamarico wants to merge 1 commit into
angular:masterfrom
calamarico:patch-1

Conversation

@calamarico

@calamarico calamarico commented May 28, 2015

Copy link
Copy Markdown
Contributor

I think this is not correct because since 1.3.0-RC.0 sonic-boltification this change: 2ae10f6 and null and undefined are passing through

@calamarico
Change in number $filter doc
ed006ac 
I think this is not correct because since 1.3.0-RC.0 sonic-boltification this change: angular@2ae10f6 and null and undefined are passing through
@googlebot

googlebot commented May 28, 2015

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@calamarico

calamarico commented May 28, 2015

Copy link
Copy Markdown
Contributor Author

I signed it!

2015-05-28 14:35 GMT+02:00 googlebot notifications@github.com:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

—
Reply to this email directly or view it on GitHub
#11963 (comment).

@googlebot

googlebot commented May 28, 2015

Copy link
Copy Markdown

CLAs look good, thanks!

@calamarico calamarico changed the title Change in number $filter doc docs(filter/number): Change description of returned value May 28, 2015
petebacondarwin pushed a commit that referenced this pull request Jun 1, 2015
@calamarico @petebacondarwin
docs(numberFilter): update to match handling of null and undefined
90621a6 
This changed in 2ae10f6, where null and
undefined are passed through.

Closes #11963
netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
@calamarico @netman92
docs(numberFilter): update to match handling of null and undefined
8d5ee7d 
This changed in 2ae10f6, where null and
undefined are passed through.

Closes angular#11963
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@calamarico @googlebot