fix($httpParamSerializerJQLike): Follow jQuery parameter serialization l...#11635
fix($httpParamSerializerJQLike): Follow jQuery parameter serialization l...#11635lgalfaso wants to merge 1 commit into
Conversation
57a82d8 to
089e246
Compare
There was a problem hiding this comment.
Minor, but I think this can be just return parts.join('&');
In paramSerializer() too.
089e246 to
551b63b
Compare
|
The travis failure looks like a flake |
|
I think we need to make a special case for date parameters: jQueryLikeParamSerializer({ dateFrom: new Date() }) === "" |
There was a problem hiding this comment.
Maybe } else if (isObject(toSerialize) && !isDate(toSerialize)) {?
…n logic Follow jQuery parameter serialization logic for nested objects. Closes angular#11551
551b63b to
e77080f
Compare
|
@gabrielmaldi you are right, fixed this case |
|
I thought this would make it into |
There was a problem hiding this comment.
If we are going to do this then we might as wel ditch the paramSerializerFactory altogether and just reference these two serializers directly in their respective providers.
There was a problem hiding this comment.
They only share serializeValue, maybe move a little more logic to this function but keep it as is?
|
One comment but otherwise LGTM |
...ogic
Follow jQuery parameter serialization logic for nested objects.
Closes #11551