This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($templateRequest): propagate HTTP status on failed requests#10628
Closed
pkozlowski-opensource wants to merge 1 commit into
Closed
fix($templateRequest): propagate HTTP status on failed requests#10628pkozlowski-opensource wants to merge 1 commit into
pkozlowski-opensource wants to merge 1 commit into
Conversation
Contributor
|
LGTM (mobile, might want another look) |
Member
Author
|
@caitp do you want to have another look at it or is it good to land? |
Member
Author
|
@caitp / @petebacondarwin / @lgalfaso (or anyone else!) - would you guys mind reviewing this one - it is pretty minimal |
Contributor
|
LGTM - feel free to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10514