Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

perf($compile): only re-$interpolate attribute values at link time if changed since compile#10411

Closed
jbedard wants to merge 1 commit into
angular:masterfrom
jbedard:interp-attr-avoid-reinterp
Closed

perf($compile): only re-$interpolate attribute values at link time if changed since compile#10411
jbedard wants to merge 1 commit into
angular:masterfrom
jbedard:interp-attr-avoid-reinterp

Conversation

@jbedard
Copy link
Copy Markdown
Contributor

@jbedard jbedard commented Dec 11, 2014

This makes the added benchmark case

  • create step ~3x faster
  • create step consumes half the memory (and half the garbage collected on destroy step)
  • GC times in all 3 steps are about 30-50% less

@googlebot
Copy link
Copy Markdown

googlebot commented Dec 11, 2014

CLAs look good, thanks!

@jbedard jbedard mentioned this pull request Dec 11, 2014
Closed
@jbedard jbedard force-pushed the interp-attr-avoid-reinterp branch 3 times, most recently from 8699d5c to d104133 Compare December 11, 2014 08:06
@jbedard jbedard force-pushed the interp-attr-avoid-reinterp branch from d104133 to 49211af Compare December 11, 2014 08:12
@lgalfaso lgalfaso added this to the 1.3.7 milestone Dec 11, 2014
@lgalfaso lgalfaso self-assigned this Dec 11, 2014
@lgalfaso
Copy link
Copy Markdown
Contributor

lgalfaso commented Dec 11, 2014

LGTM, will aim at merging this for 1.3.7

@lgalfaso
Copy link
Copy Markdown
Contributor

lgalfaso commented Dec 13, 2014

landed as 9ae0c01

@lgalfaso lgalfaso closed this Dec 13, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@lgalfaso lgalfaso

Labels

cla: yes component: misc core type: perf

Projects

None yet

Milestone

1.3.7

Development

Successfully merging this pull request may close these issues.

3 participants

@jbedard @googlebot @lgalfaso