This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($emplateRequest): simplify filtering out of transform functions#10264
Closed
pkozlowski-opensource wants to merge 1 commit into
Closed
refactor($emplateRequest): simplify filtering out of transform functions#10264pkozlowski-opensource wants to merge 1 commit into
pkozlowski-opensource wants to merge 1 commit into
Conversation
|
CLAs look good, thanks! |
Member
Author
|
Oh, it looks like I wasn't the only thinking about this change, see https://github.com/shahata/angular.js/commit/58042eefce097a4cd478e433116b39f9354a314d in #9745 |
Contributor
|
I guess the original reason for this was that IE8 didn't support it. Thankfully we don't need to worry about that anymore. |
Member
Author
Contributor
|
I thought we already merged @shahatas refactoring |
Member
Author
|
no, we didn't as it was part of more changes in #9745 (this is why it is always good idea to send small, focused PRs :-)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess it might be just me but I find it a lot easier to read / understand this chunk of code when it is written using the
.filtermethod.Unless the code was written like this for perf reasons.