Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(docs): mark builds >= 1.3.0 as stable#10117

Closed
royaldark wants to merge 1 commit into
angular:masterfrom
royaldark:fix-version-stability
Closed

chore(docs): mark builds >= 1.3.0 as stable#10117
royaldark wants to merge 1 commit into
angular:masterfrom
royaldark:fix-version-stability

Conversation

@royaldark

Copy link
Copy Markdown

Update isStable() to add builds >= 1.3.0 marked as stable. Previously, only builds with an even minor version number (1.0.x, 1.2.x) were marked as stable, while odd minor numbers (1.3.x) were marked as unstable. Now, 1.0.x, 1.2.x and 1.3+ will all be marked as stable. Prereleases remain marked as unstable, regardless of minor version.

As noted here, odd minor versions are no longer considered unstable.

See screenshot of the current (incorrect) behavior:
angular versions

@mary-poppins

Copy link
Copy Markdown

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

Update isStable() to add builds >= 1.3.0 marked as stable. Previously,
only builds with an even minor version number (1.0.x, 1.2.x) were marked
as stable, while odd minor numbers (1.3.x) were marked as unstable. Now,
1.0.x, 1.2.x and 1.3+ will all be marked as stable. Prereleases remain
marked as unstable, regardless of minor version.
@royaldark royaldark force-pushed the fix-version-stability branch from aa8e625 to d1f2dbc Compare November 19, 2014 02:17
@royaldark

Copy link
Copy Markdown
Author

@mary-poppins I used the wrong email in my original commit. Fixed.

@jeffbcross

Copy link
Copy Markdown
Contributor

CLA verified, thank you!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not what we want. It should be '1.0 || 1.2 || >=1.3 <1.4.0'

@lgalfaso lgalfaso added this to the 1.3.x milestone Nov 19, 2014
@thorn0

thorn0 commented Nov 20, 2014

Copy link
Copy Markdown
Contributor

see #10053

@petebacondarwin

Copy link
Copy Markdown
Contributor

Fixed by addb4bd

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants