This repository was archived by the owner on Dec 4, 2017. It is now read-only.
[WIP] Dart dependency injection#951
Closed
kwalrath wants to merge 7 commits into
Closed
Conversation
| <h2>User</h2> | ||
| <p id="user"> | ||
| {{userInfo}} | ||
| <button (click)=\'nextUser()\'>Next User</button> |
There was a problem hiding this comment.
The \ seems redundant. Why single quote while elsewhere in the template double quotes are used?
Contributor
Author
There was a problem hiding this comment.
I didn't notice that. You're right, " is better.
Contributor
Author
|
For some reason, I can't push to this branch any more. I'll create a new branch & PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@thso please take a look. The jade source is pretty unreadable, so I've sent you a PDF (or you could build it yourself, using this PR). Comment whichever way is easiest for you—only the TS source, on the Dart source, in email... whatever works. Thanks for your time!
Toward the end, it got a bit ugly, since the TS version was talking about very TS/JS-specific stuff, like object hashes and the fact that interfaces don't work as provider tokens. (They do work in Dart! Or at least in Dartium... I'd better check the compiled version.) I'd appreciate any help you can give me in (1) providing good code and (2) coming up with better motivations for using string and opaque tokens.