Skip to content

feat(test): karma integration and unit test sample#69

Closed
cironunes wants to merge 1 commit into
angular:masterfrom
cironunes:karma-integration
Closed

feat(test): karma integration and unit test sample#69
cironunes wants to merge 1 commit into
angular:masterfrom
cironunes:karma-integration

Conversation

@cironunes

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about source maps? don't you need to serve those too?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I don't see the proxy configuration to enable component template fetching from tests

@IgorMinar IgorMinar self-assigned this Nov 25, 2015
@cironunes

Copy link
Copy Markdown
Member Author

Thanks for the feedback @IgorMinar. I totally forgot about the source maps. I'll add them and fix the other issues to get this merged.

Todo:

  • Support source maps
  • Enable component fetching
  • Reformat code to 2 spaces
  • Put test files next to source files
  • Remove reference to KarmaIntegration
  • Remove matchers.js

@cironunes cironunes force-pushed the karma-integration branch 4 times, most recently from 55550a9 to 0ed045f Compare November 25, 2015 19:22
@cironunes

Copy link
Copy Markdown
Member Author

@IgorMinar I think that all the comments were addressed. One thing that is still missing though is the ability to run the tests using ng test instead of karma start, but we can do that later IMHO.

@IgorMinar

Copy link
Copy Markdown
Contributor

ng test can be done in a follow up pr. let me take a look at the rest.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a todo comment that once beta is out we should change this code to use a "test platform".

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@IgorMinar

Copy link
Copy Markdown
Contributor

left a few comments. the rest looks good. can you please fix the issues and merge the PR into master? (I'll make sure you have commit rights). No merge commits please. Use rebase/fast-forward merges.

@cironunes cironunes force-pushed the karma-integration branch 2 times, most recently from ee712d3 to 7f7b308 Compare November 26, 2015 00:20
@cironunes

Copy link
Copy Markdown
Member Author

OK. Just waiting for the commit rights.

@IgorMinar

Copy link
Copy Markdown
Contributor

check email. you should have an invite.

On Wed, Nov 25, 2015 at 4:33 PM Ciro Nunes notifications@github.com wrote:

OK. Just waiting for the commit rights.


Reply to this email directly or view it on GitHub
#69 (comment).

@cironunes

Copy link
Copy Markdown
Member Author

Landed as 4afd815

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants