Skip to content

feat(@angular/cli): always use ng4 in ng new - #5575

Merged
hansl merged 1 commit into
angular:masterfrom
filipesilva:remove-ng4
Mar 24, 2017
Merged

feat(@angular/cli): always use ng4 in ng new#5575
hansl merged 1 commit into
angular:masterfrom
filipesilva:remove-ng4

Conversation

@filipesilva

Copy link
Copy Markdown
Contributor

Fix #5566

@sumitarora sumitarora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"@angular/http": ">=4.0.0-beta <5.0.0",
"@angular/platform-browser": ">=4.0.0-beta <5.0.0",
"@angular/platform-browser-dynamic": ">=4.0.0-beta <5.0.0",
"@angular/router": ">=4.0.0-beta <5.0.0",

@clydin clydin Mar 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify these to ^4.0.0 ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually left these there while waiting for 4.0.0 to be released, have to update it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"@angular/platform-browser": "<%= ng4 ? '>=4.0.0-beta <5.0.0' : '^2.4.0' %>",
"@angular/platform-browser-dynamic": "<%= ng4 ? '>=4.0.0-beta <5.0.0' : '^2.4.0' %>",
"@angular/router": "<%= ng4 ? '>=4.0.0-beta <5.0.0' : '^3.4.0' %>",
"@angular/common": ">=4.0.0-beta <5.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is not beta anymore. We can safely use ^4.0.0.

@hansl
hansl merged commit baf0c7d into angular:master Mar 24, 2017
@filipesilva
filipesilva deleted the remove-ng4 branch March 26, 2017 20:39
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking: replace --ng4 flag with --ng2 flag on ng new

5 participants