Repository navigation
feat(@angular/cli): add ng4 option to ng new - #4507
Merged
Merged
Conversation
hansl
force-pushed
the
ng4
branch
3 times, most recently
from
February 8, 2017 03:06
2851b8f to
b0afe31
Compare
filipesilva
approved these changes
Feb 8, 2017
filipesilva
left a comment
Contributor
There was a problem hiding this comment.
LGTM but have a look at the node7 CI. It failed with a weird missing chunk expectation and I restarted it.
| // Otherwise create a project from scratch. | ||
| createProject = Promise.resolve() | ||
| .then(() => ng('new', 'test-project', '--skip-npm')) | ||
| .then(() => ng('new', 'test-project', '--skip-npm', argv['ng4'] ? '--ng4' : '--')) |
The xi18n command was loading everything which was slowing down starting times.
hansl
force-pushed
the
ng4
branch
2 times, most recently
from
February 8, 2017 19:51
3e92bd1 to
d162659
Compare
This allows to create a project with Angular 4 in the template. Also fixes a few issues with ng4.
Contributor
|
Should this be |
Contributor
|
Are there any plans to remove the ng4 option again once Angular 4 is released – or will it stay here forever? |
Contributor
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
This allows to create a project with Angular 4 in the template. Also fixes a few issues with ng4.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to create a project with Angular 4 in the template.
Also fixes a few issues with ng4.