Skip to content

feat(angular-cli): Add a postinstall warning for Node 4 deprecation. - #4309

Merged
hansl merged 1 commit into
angular:masterfrom
hansl:node-deprecation
Feb 1, 2017
Merged

hansl merged 1 commit into
angular:masterfrom
hansl:node-deprecation

Conversation

@hansl

@hansl hansl commented Jan 31, 2017

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: Node < 6.9 will be deprecated soon, and this will show a warning to users. Moving forward, that warning will be moved to an error with the next release.

@hansl
hansl force-pushed the node-deprecation branch 2 times, most recently from 24b2b45 to 8da772b Compare January 31, 2017 21:21
Comment thread packages/angular-cli/scripts/install.ts Outdated
Many of our dependencies are moving to deprecating Node 4 already and that would mean that we
could not update them to the latest versions which might have bug fixes and new useful features.

As a forewarning, We are also moving to "@angular/cli" with the next release, which will only

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a separate check to see if the angular-cli package is in the package.json? That way, everyone will be notified that the package is moving, not just those on 4.x.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. We're still trying to figure out where to put those warnings, since post install might be too early and be missed out when looking at the console.

@StephenFluin StephenFluin Jan 31, 2017 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this much detail? I think if we just keep it to You are running version x.x of Node, which will not be supported in future versions of the CLI. The official Node version that will be supported is 6.9 and greater.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenFluin missed that comment. Done.

@hansl
hansl force-pushed the node-deprecation branch 2 times, most recently from 1a29a2e to 4f57b38 Compare January 31, 2017 22:29
@robwormald

Copy link
Copy Markdown
Contributor

LGTM from devrel

BREAKING CHANGE: Node < 6.9 will be deprecated soon, and this will show a warning to users. Moving forward, that warning will be moved to an error with the next release.
@hansl
hansl merged commit 916e9bd into angular:master Feb 1, 2017
@hansl
hansl deleted the node-deprecation branch February 1, 2017 00:36
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
…ngular#4309)

BREAKING CHANGE: Node < 6.9 will be deprecated soon, and this will show a warning to users. Moving forward, that warning will be moved to an error with the next release.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants