Skip to content

fix(@ngtools/json-schema): values of non-existent objects should return undefined - #4300

Merged
hansl merged 1 commit into
angular:masterfrom
hansl:json-schema-null
Jan 31, 2017
Merged

hansl merged 1 commit into
angular:masterfrom
hansl:json-schema-null

Conversation

@hansl

@hansl hansl commented Jan 30, 2017

Copy link
Copy Markdown
Contributor

Also, we verify the value is null and return that instead if thats the case.

Comment thread packages/angular-cli/commands/get.ts Outdated

const value = config.get(rawArgs[0]);

console.log(value)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hansl

hansl commented Jan 31, 2017

Copy link
Copy Markdown
Contributor Author

PTAL

…rn undefined

Also, we verify the value is null and return that instead if thats the case.
@hansl
hansl merged commit 95f28fd into angular:master Jan 31, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
…rn undefined (angular#4300)

Also, we verify the value is null and return that instead if thats the case.
@hansl
hansl deleted the json-schema-null branch August 2, 2018 19:57
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants