Skip to content

perf(@ngtools/webpack): Improve rebuild performance - #4145

Merged
hansl merged 1 commit into
angular:masterfrom
hansl:perf-source-file-fix
Jan 22, 2017
Merged

hansl merged 1 commit into
angular:masterfrom
hansl:perf-source-file-fix

Conversation

@hansl

@hansl hansl commented Jan 20, 2017

Copy link
Copy Markdown
Contributor

Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: #1980, #4020, #3315

@hansl
hansl force-pushed the perf-source-file-fix branch 3 times, most recently from d8445f6 to 6661bcb Compare January 20, 2017 23:28

@filipesilva filipesilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesomesauce.

@hansl
hansl force-pushed the perf-source-file-fix branch 7 times, most recently from b293dfe to 28183cc Compare January 22, 2017 03:15
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
@hansl
hansl force-pushed the perf-source-file-fix branch from 28183cc to 1b73150 Compare January 22, 2017 04:22
@hansl
hansl merged commit 9d033e7 into angular:master Jan 22, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
Keep the TypeScript SourceFile around so we don't regenerate all of them
when we rebuild the Program. The rebuild time is now 40-50% faster for
hello world. This means all the files which haven't changed are not
reparsed.

Mentions: angular#1980, angular#4020, angular#3315
@hansl
hansl deleted the perf-source-file-fix branch August 2, 2018 19:56
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants