Repository navigation
feat(gh-pages:deploy): add aot and vendor-chunk options for gh-pages:deploy - #4073
Merged
Merged
Conversation
# Conflicts: # packages/angular-cli/commands/github-pages-deploy.ts
Contributor
|
Closed in favor of #3776 |
Contributor
|
Sorry got it the other way around, wanted to have this one open instead. |
filipesilva
suggested changes
Jan 17, 2017
filipesilva
left a comment
Contributor
There was a problem hiding this comment.
You also have to send this options onto the build command, like in #3776:
https://github.com/angular/angular-cli/blob/master/packages/angular-cli/commands/github-pages-deploy.run.ts#L67
aot: options.aot,
vendorChunk: options.vendorChunk
Contributor
Author
|
@filipesilva passed the options to the build command |
filipesilva
approved these changes
Jan 18, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There hasn't been movement on pr #3776 If either make it into master the other won't be necessary.
I don't care whose, I just want the feature. related issue #3939
Edit: whoops my fork was way behind from another pr.