Repository navigation
Conversation
filipesilva
suggested changes
Jan 9, 2017
| const testPath = | ||
| path.join(root, 'tmp', 'foo', 'src', 'app', 'non-existing-dir', 'my-comp', 'my-comp.component.ts'); | ||
| const appModule = path.join(root, 'tmp', 'foo', 'src', 'app', 'app.module.ts'); | ||
| return ng(['generate', 'component', `non-existing-dir${path.sep}myComp`]) |
Contributor
There was a problem hiding this comment.
Can you test non/existing/dir/myComp instead? It should be fine to use / everywhere, and I'd also like to be sure that nested dirs work.
Contributor
|
Adding @Brocco as a reviewer as well. I added my review but he's the authority on this topic. |
Meligy
force-pushed
the
feat/generate-creates-non-existing-dir
branch
from
January 9, 2017 16:08
88e9a58 to
c927497
Compare
Brocco
suggested changes
Jan 10, 2017
Brocco
left a comment
Contributor
There was a problem hiding this comment.
This looks good, but please add some e2e test(s) to verify the paths get created.
filipesilva
approved these changes
Jan 14, 2017
Contributor
|
@Brocco are you happy with the tests provided? |
…they do not exist fixes angular#3307
Meligy
force-pushed
the
feat/generate-creates-non-existing-dir
branch
from
January 14, 2017 23:22
c927497 to
47b476b
Compare
Brocco
approved these changes
Jan 15, 2017
Contributor
|
I just changed my review and marked this as approved. |
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
…they do not exist Fix angular#3307 Close angular#3912
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
mostafaibr
pushed a commit
to mostafaibr/angular-cli
that referenced
this pull request
May 29, 2026
…they do not exist Fix angular#3307 Close angular#3912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3307