Repository navigation
perf(@angular/build): avoid web worker channel overhead in library parallel compilation - #34422
Open
alan-agius4 wants to merge 1 commit into
Open
alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
…rallel compilation Skip creating and transferring `webWorkerChannel` (`MessageChannel`) and `webWorkerSignal` (`SharedArrayBuffer`) in `ParallelCompilation.initialize()` when `buildType === 'library'`, as library builds do not bundle web workers via `processWebWorker` and previously left ports open until the next build if `emitAffectedFiles()` was skipped due to stylesheet errors. Also replace `crypto.randomUUID()` per component stylesheet request in `parallel-worker.ts` with an incrementing numeric request counter.
alan-agius4
marked this pull request as ready for review
October 20, 2026 09:21
There was a problem hiding this comment.
Code Review
This pull request optimizes parallel compilation by making the web worker channel optional, which avoids setting it up for library builds. It also replaces UUID generation with an incrementing numeric ID for stylesheet transformation requests to improve performance, and adds a new test suite to verify these changes. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip creating and transferring
webWorkerChannel(MessageChannel) andwebWorkerSignal(SharedArrayBuffer) inParallelCompilation.initialize()whenbuildType === 'library', as library builds do not bundle web workers viaprocessWebWorkerand previously left ports open until the next build ifemitAffectedFiles()was skipped due to stylesheet errors. Also replacecrypto.randomUUID()per component stylesheet request inparallel-worker.tswith an incrementing numeric request counter.Benchmark
main