Repository navigation
Conversation
…e-library-builder
ng-packagr treats an `assets` string that is neither a file nor a directory as a glob relative to
the package root. The migration copied every string as a path, and the library builder treats such
a path as a directory, so glob assets like `docs/**/*.md` copied nothing after the migration.
Migrate strings that are neither a file nor a directory to `{ glob, input, output }` objects, as
ng-packagr resolves them.
There was a problem hiding this comment.
Code Review
This pull request updates the use-library-builder migration schematic to correctly identify and migrate ng-packagr glob string assets into glob objects, since the library builder only accepts files and directories. It also adds corresponding unit tests to verify this behavior. The review feedback suggests adding a guard to check if the resolved asset path points outside the workspace root (e.g., starting with ..) to prevent potential schematic crashes when calling tree.exists or tree.getDir.
…s in use-library-builder
…s in use-library-builder
MeAkib
force-pushed
the
fix/use-library-builder-glob-assets
branch
from
October 19, 2026 18:56
75e49d3 to
76929e6
Compare
alan-agius4
requested changes
Oct 19, 2026
…s in use-library-builder Co-authored-by: Alan Agius <alan.agius4@gmail.com>
…s in use-library-builder Co-authored-by: Alan Agius <alan.agius4@gmail.com>
MeAkib
force-pushed
the
fix/use-library-builder-glob-assets
branch
from
October 20, 2026 04:53
5ff79ee to
c39ccd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ng-packagr treats an
assetsstring that is neither a file nor a directory as a glob relative tothe package root. The migration copied every string as a path, and the library builder treats such
a path as a directory, so glob assets like
docs/**/*.mdcopied nothing after the migration.Migrate strings that are neither a file nor a directory to
{ glob, input, output }objects, asng-packagr resolves them.