Repository navigation
Conversation
…ication components The `viewEncapsulation` option of the application schematic had no effect. The root component template did not set `encapsulation`, the value was not added to the component schematic defaults, so components generated later used the default encapsulation, and the `defaultEncapsulation` option added to `bootstrapModule` in `main.ts` for NgModule applications is only used by the JIT compiler. Set `encapsulation` on the root component, add `viewEncapsulation` to the component schematic defaults in `angular.json`, and remove the ineffective `defaultEncapsulation` option from `main.ts`. Fixes angular#34388
There was a problem hiding this comment.
Code Review
This pull request updates the Angular application schematic to configure viewEncapsulation directly on the root component (via the @component decorator) instead of setting defaultEncapsulation globally in main.ts during bootstrapping. It also ensures that viewEncapsulation is added to the component schematic defaults in the workspace configuration when provided, and includes comprehensive unit tests to verify these changes. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
viewEncapsulationoption of the application schematic had no effect. The root component template did not setencapsulation, the value was not added to the component schematic defaults, so components generated later used the default encapsulation, and thedefaultEncapsulationoption added tobootstrapModuleinmain.tsfor NgModule applications is only used by the JIT compiler.Set
encapsulationon the root component, addviewEncapsulationto the component schematic defaults inangular.json, and remove the ineffectivedefaultEncapsulationoption frommain.ts.Fixes #34388