Repository navigation
Conversation
The `ng deploy` descriptions stated that the deploy builder runs for the default project when no project name is supplied, and the `ng new` long description described the initial application as the workspace's default project. The CLI no longer has a default project: architect commands use the only project that has the target, or the project in the current working directory. Describe that behavior instead.
There was a problem hiding this comment.
Code Review
This pull request updates the CLI command descriptions for the deploy and new commands to remove references to the deprecated "default project" concept, replacing them with the new resolution logic (such as using the project in the current working directory or the only project with a deploy target). The review feedback suggests refining the short description of the deploy command to fully align with this updated logic and the long description.
| override longDescription = longDescription; | ||
| describe = | ||
| 'Invokes the deploy builder for a specified project or for the default project in the workspace.'; | ||
| 'Invokes the deploy builder for a specified project or for the project in the current working directory.'; |
There was a problem hiding this comment.
The short description is slightly incomplete compared to the actual resolution logic and the updated long description. If a project name is not supplied, the CLI first attempts to run the builder for the only project in the workspace that has a deploy target, before falling back to the project in the current working directory. Updating the short description to mention this makes it more accurate and helpful for users running the command from the workspace root.
| 'Invokes the deploy builder for a specified project or for the project in the current working directory.'; | |
| 'Invokes the deploy builder for a specified project, the only project with a deploy target, or the project in the current working directory.'; |
The
ng deploydescriptions stated that the deploy builder runs for the default project when no project name is supplied, and theng newlong description described the initial application as the workspace's default project. The CLI no longer has a default project: architect commands use the only project that has the target, or the project in the current working directory. Describe that behavior instead.