Repository navigation
Conversation
…onments schematic The error for non-application projects concatenated the first sentence with the project type before evaluating the ternary, so the "Only application project types are supported" sentence was never printed and projects without a `projectType` were reported as having a "projectType" of "undefined". The third-party `server` builder warning also printed the `build` target's builder instead of the `server` target's builder. Wrap the ternary in parentheses, use the `server` target's builder in the warning, and fix the typos in both error messages.
There was a problem hiding this comment.
Code Review
This pull request fixes minor typos in error messages and logging strings within the environments schematic and adds corresponding unit tests to verify the correct behavior for non-application projects and third-party server builders. There are no review comments to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error for non-application projects concatenated the first sentence with the project type before evaluating the ternary, so the "Only application project types are supported" sentence was never printed and projects without a
projectTypewere reported as having a "projectType" of "undefined". The third-partyserverbuilder warning also printed thebuildtarget's builder instead of theservertarget's builder.Wrap the ternary in parentheses, use the
servertarget's builder in the warning, and fix the typos in both error messages.