Repository navigation
fix(@angular/build): align lazy route entry names with workspace root for SSR modulepreload - #34372
Open
alan-agius4 wants to merge 1 commit into
Open
alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for overriding the basePath compiler option in the Angular build process, ensuring it is correctly transformed to a Posix path and passed from esbuild's working directory. It also updates related tests to verify the basePath override and ensure that lazy route entry points match the ɵentryName in the server bundle. Feedback suggests falling back to process.cwd() if build.initialOptions.absWorkingDir is undefined, ensuring basePath aligns with esbuild's effective workspace root.
alan-agius4
force-pushed
the
fix/ssr-lazy-route-base-path
branch
from
October 16, 2026 07:38
8291fc5 to
8a02c48
Compare
… for SSR modulepreload Override `compilerOptions.basePath` with `build.initialOptions.absWorkingDir` when initializing the Angular compilation so `lazyRoutesTransformer` computes `ɵentryName` relative to the workspace root rather than the tsconfig directory. This matches the workspace-relative keys in `entryPointToBrowserMapping` used for SSR `modulepreload` link generation when the application's `tsconfig` is not located at the workspace root. Closes angular#34369
alan-agius4
force-pushed
the
fix/ssr-lazy-route-base-path
branch
from
October 16, 2026 07:40
8a02c48 to
997bf67
Compare
clydin
approved these changes
Oct 16, 2026
| import type * as ng from '@angular/compiler-cli'; | ||
| import type { PartialMessage } from 'esbuild'; | ||
| import * as path from 'node:path'; | ||
| import { join } from 'node:path'; |
Member
There was a problem hiding this comment.
Import doesn't seem to be used anywhere.
| return { | ||
| compilerOptions: { | ||
| ...compilerOptions, | ||
| basePath: overrides?.basePath ?? compilerOptions.basePath, |
Member
There was a problem hiding this comment.
Should this be converted to a posix path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override
compilerOptions.basePathwithbuild.initialOptions.absWorkingDirwhen initializing the Angular compilation solazyRoutesTransformercomputesɵentryNamerelative to the workspace root rather than the tsconfig directory. This matches the workspace-relative keys inentryPointToBrowserMappingused for SSRmodulepreloadlink generation when the application'stsconfigis not located at the workspace root.Closes #34369