Repository navigation
fix(@angular/build): support incremental asset updates and output cleanup in library watch mode - #34357
fix(@angular/build): support incremental asset updates and output cleanup in library watch mode#34357alan-agius4 wants to merge 1 commit into
Conversation
|
/gemini review |
55a2618 to
33a6418
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces a new BuilderState class to manage incremental compilation state, transitive resource reference tracking, and output file cleanup across watch-mode rebuilds in the Angular library builder. It refactors the builder pipeline to utilize this state, improving watch-mode asset collection and output pruning. The review feedback suggests importing and using posix.join instead of the platform-specific join in entry-points_spec.ts to ensure platform-independent path joining and prevent test failures on Windows.
95027d8 to
3d8bea0
Compare
…anup in library watch mode Ensure the library builder properly handles created, modified, and deleted assets during watch mode rebuilds, and removes stale bundle, sourcemap, and manifest output files from disk when entry points or exports are removed.
3d8bea0 to
365b651
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces output tracking and cleanup capabilities for the Angular library builder in watch mode. It updates BuilderState to track emitted bundle files, manifest files, and assets across rebuilds, allowing it to identify and queue stale or deleted files for removal from disk. The asset collection pipeline and bundler have been updated to support this tracking, and a disk deletion step has been integrated into the build action. Additionally, comprehensive unit and integration tests have been added to verify watch-mode asset and output cleanup. No review comments were provided, so there is no feedback to address.
Ensure the library builder properly handles created, modified, and deleted assets during watch mode rebuilds, and removes stale bundle, sourcemap, and manifest output files from disk when entry points or exports are removed.