refactor(@angular/build): use translation integrity for i18n inlining cache keys - #33859
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request enhances the i18n inlining process by introducing localizeVersion and translationIntegrity to improve caching efficiency. It resolves the @angular/localize package version from its manifest and computes a combined integrity string from translation files. The review feedback suggests simplifying the manual loop used to build translationIntegrity with declarative array methods, and using optional chaining when reading the parsed package manifest to prevent a potential runtime error if the manifest is null.
clydin
force-pushed
the
perf/i18n-inliner-cache-key
branch
from
August 13, 2026 19:02
6e4bc56 to
c22f040
Compare
alan-agius4
approved these changes
Aug 14, 2026
… cache keys Avoid full JSON serialization and hashing of the in-memory translation dictionary for each locale when computing persistent cache keys. Instead, use the combined translation file integrity hashes and the installed `@angular/localize` package version when available, falling back to the in-memory translation object if integrity is absent.
clydin
force-pushed
the
perf/i18n-inliner-cache-key
branch
from
August 14, 2026 13:31
c22f040 to
23878ff
Compare
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid full JSON serialization and hashing of the in-memory translation dictionary for each locale when computing persistent cache keys. Instead, use the combined translation file integrity hashes and the installed
@angular/localizepackage version when available, falling back to the in-memory translation object if integrity is absent.