Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"typescript": "~6.0.2"
},
"devDependencies": {
"@types/node": "^20.17.19",
"@types/node": "^26.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading @types/node to ^26.0.0 is invalid because Node.js 26 is not yet released, and @types/node versions correspond to Node.js major versions. This version mismatch can cause type-checking failures and compatibility issues with the project's TypeScript version. Use a version matching the supported Node.js LTS versions (e.g., ^20.17.19 or ^22.0.0).

Suggested change
"@types/node": "^26.0.0",
"@types/node": "^22.0.0",

"@types/jasmine": "~6.0.0",
"jasmine": "^6.0.0"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@angular-devkit/schematics": "^<%= schematicsVersion %>"
},
"devDependencies": {
"@types/node": "^20.17.19",
"@types/node": "^26.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading @types/node to ^26.0.0 is invalid because Node.js 26 is not yet released, and @types/node versions correspond to Node.js major versions. This version mismatch can cause type-checking failures and compatibility issues with the project's TypeScript version. Use a version matching the supported Node.js LTS versions (e.g., ^20.17.19 or ^22.0.0).

Suggested change
"@types/node": "^26.0.0",
"@types/node": "^22.0.0",

"@types/jasmine": "~6.0.0",
"jasmine": "~6.3.0",
"typescript": "~6.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"dependencies": {
"@types/express": "^5.0.1",
"@types/jasmine": "~6.0.0",
"@types/node": "^20.17.19",
"@types/node": "^26.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading @types/node to ^26.0.0 is invalid because Node.js 26 is not yet released, and @types/node versions correspond to Node.js major versions. This version mismatch can cause type-checking failures and compatibility issues with the project's TypeScript version. Use a version matching the supported Node.js LTS versions (e.g., ^20.17.19 or ^22.0.0).

Suggested change
"@types/node": "^26.0.0",
"@types/node": "^22.0.0",

"browser-sync": "^3.0.0",
"express": "^5.1.0",
"istanbul-lib-instrument": "^6.0.3",
Expand All @@ -16,7 +16,7 @@
"karma-jasmine-html-reporter": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma": "~6.4.0",
"jsdom": "^28.0.0",
"jsdom": "^30.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading jsdom to ^30.0.0 introduces a breaking change that raises the minimum Node.js version to ^22.22.2 || ^24.15.0 || >=26.0.0. Since Angular still supports Node.js v18 and v20, this upgrade will break compatibility for users running on those supported LTS versions. Revert to ^28.0.0 to maintain compatibility.

Suggested change
"jsdom": "^30.0.0",
"jsdom": "^28.0.0",

"less": "^4.2.0",
"postcss": "^8.5.3",
"prettier": "^3.8.1",
Expand Down