Skip to content

perf(@angular/build): use Map for chunk asset size lookups in budget calculator #33803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Aug 7, 2026
Merged

perf(@angular/build): use Map for chunk asset size lookups in budget calculator #33803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/angular/build/src/utils/bundle-calculator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ function calculateSizes(budget: BudgetEntry, stats: BudgetStats): Size[] {
}

abstract class Calculator {
private assetMap?: ReadonlyMap<string, number>;

constructor(
protected budget: BudgetEntry,
protected chunks: BudgetChunk[],
Expand All @@ -167,15 +169,24 @@ abstract class Calculator {
return 0;
}

if (!this.assetMap) {
const map = new Map<string, number>();
for (const asset of this.assets) {
map.set(asset.name, asset.size);
}
this.assetMap = map;
}
const assetMap = this.assetMap;

return chunk.files
.filter((file) => !file.endsWith('.map'))
.map((file) => {
const asset = this.assets.find((asset) => asset.name === file);
if (!asset) {
const assetSize = assetMap.get(file);
if (assetSize === undefined) {
throw new Error(`Could not find asset for file: ${file}`);
}

return asset.size;
return assetSize;
})
.reduce((l, r) => l + r, 0);
}
Expand Down