perf(@angular/build): replace watchpack with @parcel/watcher and chokidar - #33656
Open
clydin wants to merge 1 commit into
Open
perf(@angular/build): replace watchpack with @parcel/watcher and chokidar#33656clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
clydin
force-pushed
the
feat/replace-watchpack
branch
5 times, most recently
from
July 28, 2026 10:56
a757036 to
9ed830d
Compare
clydin
force-pushed
the
feat/replace-watchpack
branch
10 times, most recently
from
August 4, 2026 00:08
afa5b29 to
160848a
Compare
clydin
marked this pull request as ready for review
August 4, 2026 01:29
There was a problem hiding this comment.
Code Review
This pull request replaces watchpack with a custom file watcher implementation that utilizes @parcel/watcher with a chokidar fallback, updating the build action and adding unit tests. The review feedback identifies several critical issues in the new watcher implementation: path traversal bugs on Windows drive roots when using path.posix.dirname, incorrect case-sensitivity detection for non-existent directories, potential unhandled promise rejections from floating unsubscribe promises, and early termination of the cleanup loop if an unsubscription fails.
clydin
force-pushed
the
feat/replace-watchpack
branch
2 times, most recently
from
August 4, 2026 21:55
a1fed21 to
37f97d1
Compare
alan-agius4
approved these changes
Aug 7, 2026
clydin
force-pushed
the
feat/replace-watchpack
branch
from
August 7, 2026 14:52
37f97d1 to
48364f8
Compare
…idar This change replaces the watchpack file watching dependency in @angular/build with @parcel/watcher as the primary native file watcher, while falling back to chokidar for polling or unsupported environments. By leveraging @parcel/watcher's native C++ bindings (FSEvents, ReadDirectoryChangesW, inotify), file system watching is offloaded directly to OS kernel APIs, significantly reducing CPU and memory footprint during watch mode. Additionally, external directory watches are dynamically subsumed to minimize active native file handles, while early path filtering and event coalescing prevent redundant incremental rebuild triggers.
clydin
force-pushed
the
feat/replace-watchpack
branch
from
August 7, 2026 15:01
48364f8 to
7ab7e51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the watchpack file watching dependency in @angular/build with @parcel/watcher as the primary native file watcher, while falling back to chokidar for polling or unsupported environments.
By leveraging @parcel/watcher's native C++ bindings (FSEvents, ReadDirectoryChangesW, inotify), file system watching is offloaded directly to OS kernel APIs, significantly reducing CPU and memory footprint during watch mode. Additionally, external directory watches are dynamically subsumed to minimize active native file handles, while early path filtering and event coalescing prevent redundant incremental rebuild triggers.