Skip to content

fix(@angular/cli): update MCP devserver tool names to conform to spec regex#33629

Open
clydin wants to merge 1 commit into
angular:mainfrom
clydin:fix/mcp-tool-names
Open

fix(@angular/cli): update MCP devserver tool names to conform to spec regex#33629
clydin wants to merge 1 commit into
angular:mainfrom
clydin:fix/mcp-tool-names

Conversation

@clydin

@clydin clydin commented Jul 23, 2026

Copy link
Copy Markdown
Member

MCP tool names must adhere to the regular expression ^[a-zA-Z0-9_-]+$. This commit updates devserver.start, devserver.stop, and devserver.wait_for_build to use underscores (devserver_start, devserver_stop, devserver_wait_for_build) and updates all corresponding tool references and documentation across the MCP command package.

… regex

MCP tool names must adhere to the regular expression ^[a-zA-Z0-9_-]+$. This commit updates devserver.start, devserver.stop, and devserver.wait_for_build to use underscores (devserver_start, devserver_stop, devserver_wait_for_build) and updates all corresponding tool references and documentation across the MCP command package.
@clydin clydin added the target: patch This PR is targeted for the next patch release label Jul 23, 2026
@clydin clydin linked an issue Jul 23, 2026 that may be closed by this pull request
2 tasks
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces dots with underscores in MCP tool names (e.g., renaming devserver.start to devserver_start) and updates all corresponding references in descriptions and error messages. A review comment suggests fixing a minor grammatical repetition ("that that app") in the description of the devserver_start tool.

* **Keeping the Server Alive**: It is often better to keep the server alive between tool calls if you expect the user to request more
changes or run more tests, as it saves time on restarts and maintains the file watcher state. You must still call
'devserver.wait_for_build' after every change to see whether the change was successfully built and be sure that that app was updated.
'devserver_wait_for_build' after every change to see whether the change was successfully built and be sure that that app was updated.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase "that that app" is repetitive and can be simplified to "the app" to improve readability.

Suggested change
'devserver_wait_for_build' after every change to see whether the change was successfully built and be sure that that app was updated.
'devserver_wait_for_build' after every change to see whether the change was successfully built and be sure that the app was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: @angular/cli target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

angular-cli troublesome tooling name causes Claude desktop to fail

2 participants