fix(@angular/build): auto-inject localize/init in library unit tests#33453
Open
clydin wants to merge 1 commit into
Open
fix(@angular/build): auto-inject localize/init in library unit tests#33453clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request conditionally imports @angular/localize/init in virtual test bed initialization files for both Karma and Vitest builders if @angular/localize is installed in the project. It also updates the Angular localize init warning plugin to skip files with an angular: namespace. Feedback was provided to use optional chaining when checking args.namespace to prevent potential runtime errors if the namespace is undefined.
Injects '@angular/localize/init' at the top of the internal virtual initialization file (angular:test-bed-init) if '@angular/localize' is installed in the workspace. This prevents ReferenceErrors when testing libraries that consume localization APIs. Also updates the warning plugin to skip internal imports originating from the 'angular:' namespace.
5016561 to
95c6426
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Injects '@angular/localize/init' at the top of the internal virtual initialization file (angular:test-bed-init) if '@angular/localize' is installed in the workspace. This prevents ReferenceErrors when testing libraries that consume localization APIs.
Also updates the warning plugin to skip internal imports originating from the 'angular:' namespace.