fix(@schematics/angular): remove unused app tsconfig outDir#33366
Open
cyphercodes wants to merge 1 commit into
Open
fix(@schematics/angular): remove unused app tsconfig outDir#33366cyphercodes wants to merge 1 commit into
cyphercodes wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the outDir compiler option from the tsconfig.app.json.template file used in the Angular application schematic. It also updates the corresponding unit tests in index_spec.ts to assert that compilerOptions.outDir is undefined. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
New applications generated by the application schematic include an
outDirentry intsconfig.app.json. This can cause a TypeScript configuration lint warning for projects generated byng new.Issue Number: Fixes #33360
What is the new behavior?
Generated application
tsconfig.app.jsonfiles no longer include the unusedoutDircompiler option.Does this PR introduce a breaking change?
Other information
Docs are not updated because this only removes an unused generated TypeScript compiler option.
Verification:
pnpm exec bazelisk test //packages/schematics/angular:test --test_output=errorsgit diff --check