fix(@angular/ssr): avoid caching non-SSG page lookups#33365
Open
SkyZeroZx wants to merge 1 commit into
Open
Conversation
Only cache CommonEngine SSG lookup results after the target file is confirmed to be a prerendered SSG page. Missing pages and static files without the SSG marker can be derived from request URLs, so retaining those negative results allows attacker-controlled paths to grow the process cache without bound.
There was a problem hiding this comment.
Code Review
This pull request modifies the CommonEngine class in Angular SSR to optimize how SSG pages are tracked. It removes the logic that explicitly sets pageIsSSG to false when a file does not exist or matches the prerender path, and ensures that pageIsSSG is only set to true when the SSG marker is found in the static file. There are no review comments to evaluate, and I have no further feedback to provide.
SkyZeroZx
commented
Jun 11, 2026
| const isSSG = SSG_MARKER_REGEXP.test(content); | ||
| this.pageIsSSG.set(pagePath, isSSG); | ||
| if (isSSG) { | ||
| this.pageIsSSG.set(pagePath, true); |
Contributor
Author
There was a problem hiding this comment.
As I understand, I don't see any use for it when is false. Additionally, I'm not sure if we would need a test, although I can't think of a way to perform one at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only cache CommonEngine SSG lookup results after the target file is confirmed to be a prerendered SSG page.
Missing pages and static files without the SSG marker can be derived from request URLs, so retaining those negative results allows attacker-controlled paths to grow the process cache without bound. Over time, this can lead to unbounded memory growth and a denial of service.