perf(@angular/cli): optimize update schematic registry query counts by fetching package metadata lazily#33316
Open
clydin wants to merge 1 commit into
Open
perf(@angular/cli): optimize update schematic registry query counts by fetching package metadata lazily#33316clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
65c19d8 to
4ccde3d
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the Angular CLI update command to pass and utilize the workspaceRoot for package resolution, enabling support for Yarn Plug'n'Play (PnP) and lazy dependency resolution. The review feedback highlights two critical improvements: first, replacing the platform-sensitive new URL construction with path.join to prevent Windows-specific path resolution errors, which also allows simplifying the logic by using createRequire as a general fallback; second, adding a safe guard when accessing npmPackageJson['dist-tags'] to prevent potential TypeError crashes when the property is undefined.
4ccde3d to
574809d
Compare
…y fetching package metadata lazily Optimize the ng update registry requests by only querying package metadata for packages that are actually being updated, while resolving other dependencies locally from disk (with fallback to registry for uninstalled/mocked packages). This reduces network query counts by 80-90% during ng update.
574809d to
ebd4970
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the ng update registry requests by only querying package metadata for packages that are actually being updated, while resolving other dependencies locally from disk (with fallback to registry for uninstalled/mocked packages). This reduces network query counts by 80-90% during ng update.