fix(@angular/build): restrict application builder output paths to output directory#33312
Open
clydin wants to merge 1 commit into
Open
fix(@angular/build): restrict application builder output paths to output directory#33312clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces path traversal protection by ensuring that generated output files do not escape the configured output directory base. It wraps file emission and deletion processes in try-catch blocks to handle errors gracefully, and implements a robust isSubDirectory utility with corresponding unit and integration tests. The review comments point out a potential issue on Windows environments where using posix.relative directly can fail due to case-insensitive drive letter differences, and suggest using platform-specific relative instead.
…put directory Ensure all file writes and deletions produced by the application builder are strictly scoped to the configured `outputPath` base directory. This prevents path traversal vulnerabilities (e.g. setting `browser` directory to `..` or relative segments that escape the output base folder) by checking all generated paths against a refined `isSubDirectory` helper before any file system write or deletion is performed.
d9a1c8a to
323e4a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure all file writes and deletions produced by the application builder are strictly scoped to the configured
outputPathbase directory.This prevents path traversal vulnerabilities (e.g. setting
browserdirectory to..or relative segments that escape the output base folder) by checking all generated paths against a refinedisSubDirectoryhelper before any file system write or deletion is performed.