fix(@angular/cli): isolate temporary package installation from parent pnpm workspace#33303
Open
clydin wants to merge 1 commit into
Open
fix(@angular/cli): isolate temporary package installation from parent pnpm workspace#33303clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
330ac84 to
391eab3
Compare
There was a problem hiding this comment.
Code Review
This pull request prevents pnpm from traversing up the directory tree and modifying the project's workspace lockfile by writing a blank pnpm-workspace.yaml in the temporary directory. It also updates the mock host, adds unit tests, and introduces an E2E test to verify the fix. The review feedback suggests simplifying the unit tests by configuring the MockHost with the required directory structure directly in its constructor, which avoids manual spying on host.stat and type casting.
… pnpm workspace Write an empty pnpm-workspace.yaml file inside the temporary installation directory when using pnpm. This acts as a workspace boundary, preventing pnpm from searching up the directory tree and modifying the parent workspace's lockfile during ng update.
391eab3 to
eb893b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write an empty pnpm-workspace.yaml file inside the temporary installation directory when using pnpm. This acts as a workspace boundary, preventing pnpm from searching up the directory tree and modifying the parent workspace's lockfile during ng update.