Skip to content

build: disable pnpm modules purge confirmation in workspace configuration#33237

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pnpm-purge
May 21, 2026
Merged

build: disable pnpm modules purge confirmation in workspace configuration#33237
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pnpm-purge

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

No description provided.

@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label May 21, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pnpm-workspace.yaml file to disable the confirmModulesPurge setting, which prevents interactive prompts when node_modules need to be recreated. Feedback suggests providing a clearer rationale for this global change, as it might mask underlying configuration issues or should potentially be limited to CI environments using environment variables to protect local development workflows.

Comment thread pnpm-workspace.yaml
@alan-agius4 alan-agius4 changed the title build: add explanation comment to confirmModulesPurge setting build: disable pnpm modules purge confirmation in workspace configuration May 21, 2026
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels May 21, 2026
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 21, 2026
@alan-agius4 alan-agius4 merged commit 1d3ac8e into angular:main May 21, 2026
35 checks passed
@alan-agius4
Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the pnpm-purge branch May 21, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants