fix(@angular-devkit/build-angular): ensure route has leading slash in prerender builder#33014
Open
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Open
fix(@angular-devkit/build-angular): ensure route has leading slash in prerender builder#33014alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
… prerender builder Ensures that the route always starts with a leading slash when calling the render function, preventing potential issues with relative paths or incorrect URL resolution during prerendering.
There was a problem hiding this comment.
Code Review
This pull request updates the prerender builder to ensure that routes are prefixed with a leading slash during the universal rendering process. The review feedback suggests improving code readability by using startsWith('/') instead of index access and recommends centralizing the route normalization logic to prevent fragmentation and redundant checks across the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the route always starts with a leading slash when calling the render function, preventing potential issues with relative paths or incorrect URL resolution during prerendering.